Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Java configuration for Log Analytics #3269

Merged
merged 3 commits into from
Jun 25, 2018
Merged

Update Java configuration for Log Analytics #3269

merged 3 commits into from
Jun 25, 2018

Conversation

alexeldeib
Copy link
Contributor

@alexeldeib alexeldeib commented Jun 19, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci azuresdkci requested a review from marstr June 19, 2018 22:55
alexeldeib
alexeldeib commented Jun 19, 2018
View reviewed changes
specification/operationalinsights/data-plane/readme.md Outdated
@@ -134,14 +134,13 @@ output-folder: $(go-sdk-folder)/services/operationalinsights/v1/operationalinsig
## Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.

``` yaml $(java)
java:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no existing client that uses the old configuration.

alexeldeib
alexeldeib commented Jun 19, 2018
View reviewed changes
specification/operationalinsights/data-plane/readme.md
@@ -25,7 +25,7 @@ These are the global settings for the OperationalInsightsData API.

``` yaml
title: OperationalInsightsDataClient
description: Operational Insights Data Client
description: Log Analytics Data Plane Client
Copy link
Contributor Author

@alexeldeib alexeldeib Jun 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflecting branding, which has been different for some time (keeping title due to existing packages dependent on it; will override on a per package basis for new releases).

@alexeldeib alexeldeib mentioned this pull request Jun 19, 2018
Merged
@alexeldeib
Copy link
Contributor Author

Related to Azure/azure-sdk-for-java#2113

@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Jun 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2772

@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Jun 19, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2126

@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@marstr marstr requested a review from jianghaolu June 20, 2018 23:27
@marstr
Copy link
Member

marstr commented Jun 20, 2018

I'd like @jianghaolu to validate the java configuration changes. Other than that, this looks good.

jianghaolu
jianghaolu reviewed Jun 20, 2018
View reviewed changes
specification/operationalinsights/data-plane/readme.md Outdated
@@ -134,14 +134,13 @@ output-folder: $(go-sdk-folder)/services/operationalinsights/v1/operationalinsig
## Java

These settings apply only when `--java` is specified on the command line.
Please also specify `--azure-libraries-for-java-folder=<path to the root directory of your azure-libraries-for-java clone>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry -- before the changes in generation, I saw this was fixed already in gulpfile. I'll undo this change.

@marstr
Copy link
Member

marstr commented Jun 21, 2018

@jianghaolu, does the update look good to you?

@jianghaolu
Copy link
Contributor

@marstr Yes! Please feel free to merge.

@marstr marstr merged commit 5a702f1 into Azure:master Jun 25, 2018
@alexeldeib alexeldeib mentioned this pull request Jul 2, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu left review comments

@marstr marstr marstr approved these changes

Assignees

@marstr marstr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexeldeib @AutorestCI @marstr @jianghaolu